search

tosdr / browser-extensions

Browser extensions for Terms of Service; Didn't Read. “I have read and agree to the Terms” is the biggest lie on the web. We aim to fix that. Get informed instantly about websites' terms & privacy policies, with ratings and summaries from the www.tosdr.org initiative.
http://tosdr.org/downloads
GNU Affero General Public License v3.0
399 stars 45 forks source link

about:addons tab reopens itself frequently #77

Closed kainino0x closed 3 years ago

kainino0x commented 3 years ago

Describe the bug Frequently (I think every time tosdr updates, or maybe every time firefox updates, or every time both update at the same time, or something), it opens a tab in my browser to the tosdr "options" pane in about:addons. This started at least a few months ago.

To Reproduce Steps to reproduce the behavior:

  1. Install tosdr extension
  2. Wait for tosdr update, or something
  3. Restart firefox
  4. Tab opens after a few seconds

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Console Log If applicable, add console logs by enabling the Debug Option in Options -> Advanced Mode

Desktop (please complete the following information):

Extension (please complete the following information):

Additional context I suspect this was supposed to happen one time to let me know that the options were there and could be set. But now it just happens all the time.

JustinBack commented 3 years ago

This is currently intended behavior on extension update and installation

https://github.com/tosdr/browser-extensions/blob/633dfef41541914692e393b6038b877eb690fb8a/src/background.js#L132-L136

kainino0x commented 3 years ago

Ah, I see. Unfortunately I think I will have to uninstall the extension then. It's very disruptive to have the options page open over whatever I'm doing, 30 seconds after opening the browser, every few days. (Also I remembered this happens in Chrome too.)

JustinBack commented 3 years ago

I see, well it should only happen when the extension updates (not every couple days, as we do not push updates that frequently).

I cannot reproduce this issue on my firefox installation, and it shouldnt happen in the first place (as you can see, only on installation and update of the extension). I'll look into this

kainino0x commented 3 years ago

It's very possible that it's happening more often for me because I use Firefox Nightly, so the browser gets an update every day. I will pay closer attention to how often this happens and try to report back. Thanks for the help!