[fix] Fixed the Gemfile to work on Windows (+ other general changes) - Githubissues

tosdr / edit.tosdr.org

👍👎 A new web app to rate services

https://edit.tosdr.org

GNU Affero General Public License v3.0

211 stars 37 forks source link

[fix] Fixed the Gemfile to work on Windows (+ other general changes) #1113

Open EarldridgeJazzedPineda opened 1 year ago

EarldridgeJazzedPineda commented 1 year ago

[x] Are you working on the latest release?
[x] Have you tested it locally?
[x] Please explain your change
[x] I have opened a Jira Issue for this Pull Request
[x] My Squashed Commit Message Contains the Issue Key e.g Feature: EDIT-12 Added XXX Thanks !

Version 1.2.13 This version contains fixes for the Gemfile, in order the make Phoenix work on Microsoft Windows.

The version for the gem 'pg' has been upgraded to 1.4.
Due to some problems compiling the gem 'mini_racer', the Gemfile is modified so that it does not compile on Windows. I am not even sure if that gem is needed anyway.
Because 'stackprof' is not officially supported on Windows, the Gemfile is modified so that it will not be installed on Windows.
Added 4 new gems: 'sys-proctable', 'fast_stack', 'wdm' (for Windows Only), and 'tzinfo-data'.

EarldridgeJazzedPineda commented 1 year ago

@JustinBack PLEASE HELP ME NOW

JustinBack commented 1 year ago

Thats correct, Jira is for internal ToS;DR use only. However I've created an issue for it

https://tosdr.atlassian.net/browse/EDIT-95

Will test the PR and if all goes well, merge it :-)

EarldridgeJazzedPineda commented 1 year ago

OK now?

EarldridgeJazzedPineda commented 1 year ago

Justin, is it okay to merge now?

JustinBack commented 1 year ago

We are still discussing internally things related to the dependencies.

JustinBack commented 1 year ago

I've had talks with @madoleary and we noticed that adding those dependencies breaks our Gitpod Integration, the CI seems to fail and running it in a linux environment fails.

Especially the dependencies are a huge problem in this PR as we cannot really test the breaking change from pg 0.21 to 1.4, as well as adding a lot of dependencies on all OS just to run the dev environment on windows

+ gem 'sys-proctable'
+ gem 'fast_stack'
+ gem 'tzinfo-data'

We feel like making certain local modifications when trying to spin up an open source project in dev env is just kind of the way it is when working on open source stuff.

You are free to use Gitpod (as its free for a generous amount of time) and spins up a cloud-based ready-to-code instance of Phoenix if you like to contribute to ToS;DR.

Though we like your changes to the quickstart and would like to merge those!

If you'd like to, you can contribute a INSTALL_windows.bat to accommodate the changes to the windows machine.

Once we've migrated to Ruby 3, the compability might be better with Windows, so don't take this as a "we would never support Windows" :-)

EarldridgeJazzedPineda commented 1 year ago

Okay, I will try to fix those

EarldridgeJazzedPineda commented 1 year ago

OK now?

EarldridgeJazzedPineda commented 1 year ago

Okay?