Closed michielbdejong closed 3 years ago
I should first get https://github.com/ambanum/CGUs/pull/71 merged with the limited number of docs there. Then I should create a branch which has all the docs from both tosback and ETO (also ones without doc type). Then I should set up an instance on Heroku that runs my branch. should it export to git? I can fork ambanum/CGUs-versions and ambanum/CGUs-snapshots so that we can use those as the data source for both tosback and ETO.
What to do if a document is not on ambanum/CGUs? Run a shadow instance?
I guess it depends how easily you want contributors to add documents vs how much these documents should be reviewed. You could very well have a separate instance of CGUs with your own service declarations, and regular upstream imports into the βmainβ CGUs instance that could then publish to CGUs-versions π
I'm curious about what is ETO!
Ah, ETO is just "edit.tosdr.org" :)
I guess we should add all rules that pass validation to ambanum/CGUs. https://github.com/ambanum/CGUs/pull/88#issuecomment-674035419 already helps a lot. I'll see how far I can get. If a document is not admitted in ambanum/CGUs then maybe it should also not be admitted in edit.tosdr.org.
I switched over https://tosback.org today. Will edit the edit.tosdr.org code to:
Then:
Working on https://github.com/tosdr/edit.tosdr.org/pull/956 first as it's related and something I also want to add.
Or maybe we should stop putting crawled text in postgres and just let edit.tosdr.org load it from GitHub? At least we need a script that checks if point quotes need to be updated.
Maybe 'Crawl Document' should just fetch&save the markdown, like https://raw.githubusercontent.com/ambanum/CGUs-versions/master/Facebook/Commercial%20Terms.md
What to do if a document is not on ambanum/CGUs? Run a shadow instance?