tosdr / tosback2

Reimplementing TOSBack with Ruby and using git to see TOS changes!
http://tosback.org
GNU General Public License v2.0
125 stars 32 forks source link

Add rule for Signal #49

Closed Vinnl closed 5 years ago

Vinnl commented 5 years ago

Note that I haven't been able to test the XPath.

Unfortunately the Terms and Privacy Policy are located on the same page, and not in separate DOM elements with their own IDs. I believe that theoretically it should be possible to select all elements in between different elements (i.e. everything between h2#terms-of-service and h2#privacy-policy for the ToS, and everything beyond h2#privacy-policy in that element for the privacy policy), but my XPath-fu is not good enough for that. Thus, it now just crawls both at once, and hopes the layout doesn't change significantly.

michielbdejong commented 5 years ago

thanks! i'll have a look.