search

tosdr / tosdr.org

ARCHIVED Source code for tosdr.org
https://github.com/tosdr/CrispCMS
GNU Affero General Public License v3.0
454 stars 28 forks source link

Only include logos that actually exist #242

Closed galfert closed 4 years ago

galfert commented 4 years ago

Currently when loading the frontpage, the browser makes 942 requests. 742 of those are for logo images that don't actually exist, resulting in 404s and broken image icons next to the service names:

Screenshot 2020-08-01 at 19 33 43

This PR checks if the logo file is actually available before including it on the generated page:

Screenshot 2020-08-01 at 19 34 00

This way the number of requests is reduced to 200 and no 404s.

raucao commented 4 years ago

Would be nice if someone could have a look at this soon.