search

toshas / torch-householder

Efficient Householder Transformation in PyTorch
Other
60 stars 2 forks source link

Support of complex tensors #6

Closed bytesnake closed 2 years ago

bytesnake commented 2 years ago

I need support for complex datatype to learn a unitary matrix. How much effort would it be to add that?

toshas commented 2 years ago

It depends on how much of the existing code can be re-used. These days I don't have throughput to support extensions, so a pull request with a discussion would be very welcome!

bytesnake commented 2 years ago

maybe it's even sufficient to just drop those guards as you are only using (badd)bmm which has added complex support recently

bytesnake commented 2 years ago

I will extend testing a bit and submit a PR later this week

bytesnake commented 2 years ago

actually solved the problem in real domain, so closing this :)