search

toshiaki1729 / dataset-tag-editor-standalone

WebUI to edit dataset captions for txt2img models
MIT License
129 stars 13 forks source link

Image selection not working #31

Closed ccharest93 closed 4 months ago

ccharest93 commented 4 months ago

While using gradio==3.50.2 as per #30. I was getting a bug where image selection wasn't properly working. Whenever i would click on an image Selected Image : would stay empty. I fixed it by modifying

https://github.com/toshiaki1729/dataset-tag-editor-standalone/blob/f13a919fabb71516c679493a488913f6d0723ea4/javascript/10_modified_gallery.js#L12

to

this.#items_selector = this.#elem.querySelectorAll('button.preview > div.thumbnails > button.thumbnail-item')

toshiaki1729 commented 4 months ago

I've updated gradio to 4.28.3 in >= ver0.0.6. Selection behavior is completely changed and the issue may be solved. I'm grad if you can check it.