Minor rewrite to avoid globally updating helm-org-ql-actions

toshism / org-linker

GNU General Public License v3.0

21 stars 4 forks source link

Minor rewrite to avoid globally updating helm-org-ql-actions #3

Closed akirak closed 3 years ago

akirak commented 3 years ago

I don't like the idea of destructively updating global variables like helm-org-ql-actions and then rolling it back. For example, helm has a feature of resuming the previous session, where the current implementation wouldn't work as expected.

Instead, I'd suggest copying and pasting the implementation of helm-org-ql function and setting the action of the source.

P.S. I reached this package via Karl Voit's blog post on using org-edna. Sorry for missing the PR description at first.

toshism commented 3 years ago

I agree. I don't like the way I modify helm-org-ql-actions either. I'll try to take a look at this today.

Thanks!

akirak commented 3 years ago

I've resolved the conflicts, so it can be merged.

akirak commented 3 years ago

I've also made some changes to banish lint warnings.

toshism commented 3 years ago

Awesome, thanks!

toshism commented 3 years ago

FYI: melpa/melpa#7244

Excellent, thanks!