search

toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.34k stars 95 forks source link

ci(broken-link-checker): 망가진 링크를 자동으로 잡도록 워크플로우 스케줄링 #109

Closed manudeli closed 5 months ago

manudeli commented 5 months ago

Overview

이 변경이 추가되면 매일 문서의 모든 link를 자동으로 체크하고 문제가 없는 지 알려줍니다. 또한 수동으로 workflow_dispatch를 사용해 수동으로 작동시킬 수도 있습니다

현재도 이미 broken link가 있습니다. 이러한 오류를 조기에 발견하고 해결할 수 있게 됩니다

image

https://es-hangul.slash.page/docs/api/chosungIncludes 이 페이지에 들어가서 수정하기 버튼을 누르면 잘못된 링크로 보내지는데 이것을 자동으로 잡을 수 있습니다 해결은 다른 PR에서 수정되면 좋겠습니다

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: b8edb175b33d2fe0ecaa1a1ab62c4dd600414c31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 1, 2024 0:18am
codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (4d479b0) to head (b8edb17).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/109/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #109 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 13 13 Lines 206 206 Branches 46 46 ======================================= Hits 205 205 Misses 1 1 ```
juno7803 commented 5 months ago

본문에 언급해주신 https://es-hangul.slash.page/docs/api/chosungIncludes 문서는 #102 에서 머지된 후 제대로 배포되지 않아 발생하는 문제 같습니다! (link-checker 덕분에 발견할 수 있었군요 👍) @okinawaa 혹시 한번 확인 부탁드려도 될까요?!