toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.34k stars 95 forks source link

fix: @typescript-eslint/naming-convention 이 실제로 잘 동작하도록 eslintrc.js의 설정을 변경합니다. #111

Closed juno7803 closed 5 months ago

juno7803 commented 5 months ago

Overview

docs아래 경로에서 yarn lint를 돌려보았을 때, 아래와 같이 경고메시지가 나타나고 있어 해당 문제를 수정한 PR이에요.

image
항목 AS-IS TO-BE
스샷 image image
설명 parserOptions.parser를 설정하지 않은 경우, naming-convention에 맞지 않는 snake_case의 variable이 통과함 parserOptions.parser를 true로 설정한 경우, naming-convention에 맞지 않는 snake_case의 variable에 에러를 띄워줌

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 5, 2024 6:31am
changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 7852550ff48a2f7c8fe26f84d37d9e97938f95df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (0cd45e4) to head (8f9aec6).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/111/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #111 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 13 13 Lines 206 206 Branches 46 46 ======================================= Hits 205 205 Misses 1 1 ```