toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.34k stars 95 forks source link

docs: chosungIncludes 문서파일에서 title을 지정합니다. #112

Closed okinawaa closed 5 months ago

okinawaa commented 5 months ago

Overview

다음과 같은 이슈가 있었습니다.

image

이를 해결합니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: f378c1b739b8b8056078387b97ad9c6a20b38b0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 5, 2024 6:32am
codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (d1e39df) to head (f378c1b).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/112/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #112 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 13 13 Lines 206 206 Branches 46 46 ======================================= Hits 205 205 Misses 1 1 ```
manudeli commented 5 months ago

@okinawaa @juno7803 제 생각에는 update안된 것은 vercel build cache 때문일 거 같아요. suspensive 공식문서을 nextra로 관리하면서 비슷한 문제를 겪었거든요. 아래와 같이 env 추가하면 해결 될 거에요

관련 논의

image
okinawaa commented 5 months ago

@manudeli 넵 감사합니다! 요 PR 에 title추가하는것도 다른 문서와의 통일성을 위해 추가해야하는것은 좋을 것 같아요!!