toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.26k stars 85 forks source link

fix: removeLastHangulCharacter 호환성 개선 - 문자열의 마지막 글자 가져오는 로직 수정 #113

Closed jungwoo3490 closed 3 months ago

jungwoo3490 commented 3 months ago

Overview

83 과 같은 이유로 호환성 개선을 위해 removeLastHangulCharacter에서 문자열의 마지막 글자를 가져오는 로직을 수정하였습니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 1, 2024 6:21pm
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: f235a1844506935f68f4200b704a4865221b76c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (5379e66) to head (f235a18).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/113/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #113 +/- ## ======================================= Coverage 99.51% 99.51% ======================================= Files 13 13 Lines 206 206 Branches 46 46 ======================================= Hits 205 205 Misses 1 1 ```