toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.26k stars 85 forks source link

fix: Adopters 컴포넌트를 수정합니다 #117

Closed po4tion closed 3 months ago

po4tion commented 3 months ago

Overview

  1. Adopters 컴포넌트의 div 태그의 스타일 작성법을 다른 컴포넌트들과 동일하게 tailwindcss로 변경하였습니다
  2. Image 태그에 올바르지 않게 적용된 props를 수정하였습니다.

Image 태그에 DOM element가 지원하지 않는 darkSrc 속성이 적용됨.

image

image

eslint rule 중 하나인 jsx-a11y/alt-text로 인해 alt prop을 컴포넌트에 명시해야 함.

alt 값을 굳이 명시하고 싶지 않다면 eslint rule 설정을 변경하는 것도 선택지 중 하나인 것 같습니다.

image

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: bc171ad8d079e325d2955d5e4db337aaa7670de5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 6, 2024 3:59pm
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (dae9deb) to head (bc171ad).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/117/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #117 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 206 206 Branches 46 46 ========================================= Hits 206 206 ```