toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.34k stars 95 forks source link

fix: 코드 효율 개선 #124

Closed crucifyer closed 4 months ago

crucifyer commented 4 months ago

Overview

정규식 효율개선, 불필요한 계산의 생략을 했습니다. 각각의 commit 메세지를 참조해주세요.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 5e122b23c60eff4a42c1164a6a8f9d8c03dfd777

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 29, 2024 11:34am
codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.72%. Comparing base (db94449) to head (ed2b72d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/124/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #124 +/- ## ========================================== - Coverage 99.56% 98.72% -0.85% ========================================== Files 14 14 Lines 230 235 +5 Branches 51 53 +2 ========================================== + Hits 229 232 +3 - Misses 1 3 +2 ```