toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.34k stars 95 forks source link

feat: 숫자로 된 금액을 국립국어원 규칙의 한글 읽기로 변환합니다. #125

Closed crucifyer closed 4 months ago

crucifyer commented 4 months ago

Overview

숫자로 된 금액을 국립국어원 규칙의 한글 읽기로 변환합니다.

amountsToHangul('15,201,100'); // '일천오백이십만천백';
amountsToHangul('120,030원'); // '일십이만삼십' - 숫자 외 문자 무시
amountsToHangul('392.24'); // '삼백구십이' - 소수점 무시

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: a803e901c73c1cc33299616991618bb84d0d2a80

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 23, 2024 1:57am
codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@c9afca0). Learn more about missing BASE report.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/125/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #125 +/- ## ======================================= Coverage ? 99.56% ======================================= Files ? 14 Lines ? 230 Branches ? 51 ======================================= Hits ? 229 Misses ? 1 Partials ? 0 ```
okinawaa commented 4 months ago

1.3.6 버전에서 반영되었어요. 정말 감사합니다!!