search

toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.34k stars 95 forks source link

feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가 ( #128 이슈에 대한 ) #133

Closed KNU-K closed 4 months ago

KNU-K commented 4 months ago

feat : 문장의 각 단어 중 첫 문자만 뽑는 함수추가

test 및 함수 추가

issue 를 보고 해당 PR을 추가하게되었습니다

Overview

문장 내에서 단어의 첫 문자만 뽑는 함수를 추가하였습니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 3ffcd891ccc9ed2f0c2bbd0945c5fab970a8c0cb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 29, 2024 1:51pm
KNU-K commented 4 months ago

@po4tion 추가했습니다. 확인 부탁드립니다.

KNU-K commented 4 months ago

@okinawaa 문서화는 어디서 진행하면될까요?

okinawaa commented 4 months ago

다른 메서드들의 .ko.mdx .en.mdx 참고하셔서 일관성있게 진행해주시면 좋을 것 같아요!

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.79%. Comparing base (f0195b2) to head (3ffcd89).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/133/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #133 +/- ## ======================================= Coverage 98.78% 98.79% ======================================= Files 14 15 +1 Lines 247 249 +2 Branches 55 55 ======================================= + Hits 244 246 +2 Misses 3 3 ```
KNU-K commented 4 months ago

@okinawaa 감사합니다.