search

toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.34k stars 95 forks source link

fix: 일관된 한글 표기법 적용 #138

Closed Collection50 closed 3 months ago

Collection50 commented 4 months ago

Overview


PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

close #131

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 44db24e8ac77886d3f5859c2bf4b71fdbc4ba1e9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 12, 2024 3:47pm
Collection50 commented 4 months ago

안녕하세요 ! @okinawaa

image

Jongsung, Chosung 등을 사용할 수 없다고 오류가 발생해요 ! 해결 방법을 알려주시면 적용하겠습니다 !

okinawaa commented 4 months ago

@Collection50

Jongsung, Chosung 등을 사용할 수 없다고 오류가 발생해요 ! 해결 방법을 알려주시면 적용하겠습니다 !

172 이 머지되어서 해결되었을 것 같아요! 감사합니다.

Collection50 commented 4 months ago

안녕하세요 @okinawaa !

작업 완료 했습니다 !

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.30769% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.18%. Comparing base (135e419) to head (44db24e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/138/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #138 +/- ## =========================================== - Coverage 100.00% 95.18% -4.82% =========================================== Files 16 17 +1 Lines 275 291 +16 Branches 66 67 +1 =========================================== + Hits 275 277 +2 - Misses 0 13 +13 - Partials 0 1 +1 ```
okinawaa commented 3 months ago

src/index.ts에서 chosengIncludes를 export 해줘야할것 같아요

okinawaa commented 3 months ago

컨플릭트도 해결 부탁드릴게요!

okinawaa commented 3 months ago

_internal/src 쪽에서 CI 오류가 발생하고있어요.

Collection50 commented 3 months ago

_internal/src 쪽에서 CI 오류가 발생하고있어요.

해결했습니다 !

crucifyer commented 3 months ago

HANGUL_CHARACTERS_BY_FIRST_INDEX HANGUL_CHARACTERS_BY_MIDDLE_INDEX HANGUL_CHARACTERS_BY_LAST_INDEX 이것도 초,중,종으로 통일이 필요하지 않을까요?