search

toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

fix: 소수점 추가 후 발생한 '영'읽기 버그 수정 #159

Closed crucifyer closed 2 months ago

crucifyer commented 2 months ago

Overview

소수점을 고려하지 않았기 때문에 '영' 읽기가 없었습니다. 소수점이 추가되었으니 0.0000 같은 것의 읽기의 경우도 '영'으로 통일하고, 완전히 비었을때만 공백을 반환합니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: eb1e5eaaa70e767d2dd52045882ab0f7517baf16

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 6:36am
codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.61%. Comparing base (0bd21e7) to head (0f2da08).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/159/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #159 +/- ## ======================================= Coverage 99.60% 99.61% ======================================= Files 16 16 Lines 255 260 +5 Branches 56 58 +2 ======================================= + Hits 254 259 +5 Misses 1 1 ```
crucifyer commented 2 months ago

소수점이 들어가서 돈 읽기에서 멀어진 듯 한데, 명칭 변경이 필요할 것 같네요.

crucifyer commented 2 months ago

그리고, 돈 읽기라서 10000 을 일만 으로 읽게 되어 있습니다. 돈이 아닌경우 그냥 만 으로 읽는게 자연스러울겁니다.

okinawaa commented 2 months ago

소수점이 들어가서 돈 읽기에서 멀어진 듯 한데, 명칭 변경이 필요할 것 같네요.

저도 고민해봤는데, amount라는것이 소수점에도 사용된다고 해서 괜찮다고 생각했어요!