toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

Fix: 일관된 toThrowError 메서드 사용 #166

Closed fe-dudu closed 2 months ago

fe-dudu commented 2 months ago

Overview

https://github.com/toss/es-hangul/pull/135 에러를 테스트할때 assert.throws, toThrowError 대신 일관되게 toThrowError 메서드를 사용합니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 0:10am
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: a0916e06888a80d0cbf2c1aa9c8b64b5c5500106

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (48f632c) to head (a0916e0).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/166/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #166 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 16 16 Lines 260 260 Branches 58 58 ========================================= Hits 260 260 ```