toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

chore: eslint + vscode extension setting for cspell #171

Closed minsoo-web closed 2 months ago

minsoo-web commented 2 months ago

Overview

기존 세팅은 vscode extension 을 쓰시는 분들에게는 여전히 오타로 표기되는 문제가 있습니다. eslint 설정과 vscode extension 모두 대응하기 위한 방법으로 cspell.json 을 추가합니다.

Before

image

After

image

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: a28357caf22a5bdd189d4b5a715dd87a2b28f2e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 5, 2024 0:30am
codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (16b77b2) to head (a28357c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/171/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #171 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 16 16 Lines 260 261 +1 Branches 58 58 ========================================= + Hits 260 261 +1 ```
minsoo-web commented 2 months ago

131 이슈를 지금 봐서 draft 로 변경합니다

minsoo-web commented 2 months ago

138 PR 에서 하고자 하는 바와 너무 달라져서 close 합니다