toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

feat: 문자열 내부에 자음이나 모음이 문자로서 조합이 가능한지 검사하는 함수 `needAssemble`를 추가 #177

Closed wet6123 closed 1 month ago

wet6123 commented 2 months ago

Overview

129 에서 제안된 문자열 내부에 자음이나 모음이 문자로서 조합이 가능한지 검사하는 함수 needAssemble을 추가합니다.

function needAssemble(hangul: string): boolean;

needAssemble('아버지가 방에 들어갑니다'); // false
needAssemble('아버지가 방ㅇㅔ 들어갑니다'); // true
needAssemble('아버지가 방에 들어갑니다ㅇ'); // true
needAssemble('아버지가 방에 들어갑닏ㅏ'); // true

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: cc9facb63ef3a13809ada97244bffb3c6c235fe0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 6:29am
okinawaa commented 1 month ago

좋은 기능 구현해주셔서 감사합니다, https://github.com/toss/es-hangul/issues/129#issuecomment-2227218408 에서 논의한 이유로 이 PR은 닫겠습니다!