toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

feat: 문자열에서 한글을 추출해주는 extractHangul 함수를 제거합니다 #186

Closed okinawaa closed 1 month ago

okinawaa commented 1 month ago

Overview

https://github.com/toss/es-hangul/discussions/176 에서 논의한 결과 extrachHangul은 한글의 원리를 해결하는것이 아닌, 자바스크립트 일반 메서드로도 해결이 가능하므로 es-hangul에서 제공해주지 않아도 된다고 생각합니다.

isHangul 함수만 제공해서 [..."가a나b"].filter(isHangul).join('')처럼 사용하게 하는 것이 더 나은 인터페이스라고 생각해요.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 3:34pm
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 2bce1b36a3ecf9297d4eaeeea35f3869d5ecfd64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (587fb04) to head (2bce1b3).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/186/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## v2 #186 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 16 15 -1 Lines 260 273 +13 Branches 58 66 +8 ========================================= + Hits 260 273 +13 ```