toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

feat: hangulIncludes 함수를 삭제합니다 #188

Closed okinawaa closed 1 month ago

okinawaa commented 1 month ago

Overview

hangulIncludes 함수를 삭제합니다 #176 에서 논의한 결과, hangulIncludes는 삭제하기로 합니다.

개발자에 따라 hangulIncludes를 아래와 같이 사용하는 경우 true, false 둘 중 어떤 것을 반환하는게 맞을지 다르게 판단하는 경우가 존재합니다.

hangulIncludes('사과', '삭'); //

hangulIncludes는 이미 제공해주는 disassembleHangul 함수를 사용해서 사용자가 직접 구현할 수 있고, 더 다양한 유즈케이스까지 대응하는 hangulIncludes를 만들 수 있기때문에 es-hangul에서는 제공해주지 않으면 좋겠다고 생각해서 제거합니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 14, 2024 7:50am
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 18c264a72becdbd8f4ba0b6b61a2741c3a92746e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (v2@357ff9f). Learn more about missing BASE report.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/188/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/188?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## v2 #188 +/- ## ===================================== Coverage ? 95.08% ===================================== Files ? 15 Lines ? 285 Branches ? 67 ===================================== Hits ? 271 Misses ? 13 Partials ? 1 ```
manudeli commented 1 month ago

@okinawaa conflict 해결 부탁드려요