toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

v2 #189

Closed okinawaa closed 1 month ago

okinawaa commented 1 month ago

Overview

  1. fix #158

  2. fix #170

  3. 불필요한 함수 제거

  4. 함수명 수정

  5. 잘못 export된 함수들 수정

PR Checklist

📝 major version update squash merge를 사용하지 않습니다

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 6:37pm
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 4c3e9f97ae0b10d21c602b6495531b425185aa7b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.82%. Comparing base (78cde66) to head (3c5299d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/189/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #189 +/- ## ========================================== + Coverage 97.61% 99.82% +2.21% ========================================== Files 32 29 -3 Lines 629 583 -46 Branches 146 141 -5 ========================================== - Hits 614 582 -32 + Misses 14 1 -13 + Partials 1 0 -1 ```
manudeli commented 1 month ago

https://github.com/changesets/changesets/issues/665 참고하기 좋은 이슈인 것 같아서 남겨요

manudeli commented 1 month ago

squash merge를 반드시 사용하지 않아야 합니다. 리마인드

manudeli commented 1 month ago

squash merge를 반드시 사용하지 않아야 합니다. 리마인드

매우 중요해서 리마인드