toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

feat: 일관된 이름 짓기 규칙에 알맞게 함수명 수정 #191

Closed Collection50 closed 1 month ago

Collection50 commented 1 month ago

Overview

170 을 해결했습니다.

PR Checklist

close #170

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 8a9aa39f68e5e819bf8ec001b4f45f20efbbc7ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 20, 2024 7:43am
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.69%. Comparing base (b6cde8e) to head (8a9aa39).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/191/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #191 +/- ## ========================================== - Coverage 95.18% 94.69% -0.49% ========================================== Files 17 15 -2 Lines 291 283 -8 Branches 67 66 -1 ========================================== - Hits 277 268 -9 - Misses 13 14 +1 Partials 1 1 ```
Collection50 commented 1 month ago

고민점은 아래와 같습니다 !

  1. amountToMoneyUnit에서 hangul을 제외하면 amountTo로 되어 어색한 점이 많다고 생각했습니다. 금액으로 반환하는 특성을 고려하여 네이밍했습니다 !!
  2. ./_internal/hangul의 폴더명은 hangul로 시작하고합니다. 내부에서도 isHangulCharacter, isHangulAlphabethangul을 제외하면 기능이 무엇인지 유추되지 않을 것이라고 판단해 네이밍을 그대로 유지했습니다 !!
okinawaa commented 1 month ago

204 와 작업 범위가 같다면, 이 PR은 닫아도 될까요?

Collection50 commented 1 month ago

https://github.com/toss/es-hangul/pull/204 와 작업 범위가 같다면, 이 PR은 닫아도 될까요?

넵 !