toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

feat: getChoseng을 utils에서 별도 함수로 분리합니다. #192

Closed okinawaa closed 1 month ago

okinawaa commented 1 month ago

Overview

158

  1. getChoseong은 원자적인 함수이므로, 독립적인 함수로 위치하는게 자연스럽다고 생각했습니다.
  2. 과거에 잘못사용되던 getChosung을 제거합니다

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 21f67f97062a68308dcac2727781557548e4e8a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 21, 2024 8:00am
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.02%. Comparing base (fec20e8) to head (21f67f9).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/192/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## v2 #192 +/- ## ========================================== + Coverage 95.05% 96.02% +0.97% ========================================== Files 14 15 +1 Lines 283 277 -6 Branches 67 67 ========================================== - Hits 269 266 -3 + Misses 13 10 -3 Partials 1 1 ```