toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

feat: `canBeChoseong`, `canBeJungseong`, `canBeJongseong` 을 utils에서 별도 함수로 분리합니다. #193

Closed okinawaa closed 1 month ago

okinawaa commented 1 month ago

Overview

158

  1. canBeChoseong, canBeJungseong, canBeJongseong은 원자적인 함수이므로, 독립적인 함수로 위치하는게 자연스럽다고 생각했습니다.
  2. 일관화된 변수명을 위해 canBe~chosung 으로 사용된 부분을 제거합니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 23, 2024 2:57am
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 8ea58f8eada2f7ec81654a16bcf10d49c856bd93

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.38%. Comparing base (fec20e8) to head (62bfb98).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/193/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## v2 #193 +/- ## ========================================== + Coverage 95.05% 96.38% +1.33% ========================================== Files 14 15 +1 Lines 283 277 -6 Branches 67 67 ========================================== - Hits 269 267 -2 + Misses 13 9 -4 Partials 1 1 ```