toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

feat: `hasBatchim` 을 utils에서 별도 함수로 분리합니다. #195

Closed okinawaa closed 1 month ago

okinawaa commented 1 month ago

Overview

158

  1. hasBatchim, canBeJungseong, canBeJongseong은 원자적인 함수이므로, 독립적인 함수로 위치하는게 자연스럽다고 생각했습니다.
  2. hasSingleBatchim 이 hasBatchim과 하는 역할이 비슷하므로, 옵션으로 제어할 수 있도록 하고 함수를 통합합니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 23, 2024 3:15am
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 1d2e98c8f47e1af964e4867fcddb97da9527b908

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.36%. Comparing base (0cfbed6) to head (1d2e98c). Report is 1 commits behind head on v2.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/195/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/195?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## v2 #195 +/- ## ========================================== - Coverage 97.41% 97.36% -0.05% ========================================== Files 16 16 Lines 271 266 -5 Branches 67 67 ========================================== - Hits 264 259 -5 Misses 6 6 Partials 1 1 ```