toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

chore: josa 테스트 코드 정리 #202

Closed BO-LIKE-CHICKEN closed 1 month ago

BO-LIKE-CHICKEN commented 1 month ago

Overview

201 을 작업하던 도중 josa의 테스트코드에 불필요한 설명이 포함되어 있음을 확인했습니다.

(아마 Slash 시절 작성된 코드로 추정됩니다.)

다른 테스트코드에서도 쓰이는 경우가 없기에 삭제했습니다.

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 40566d729d926aed65206b96434ff0c73f883700

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:57am
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.18%. Comparing base (506d0fc) to head (40566d7).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/202/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #202 +/- ## ======================================= Coverage 95.18% 95.18% ======================================= Files 17 17 Lines 291 291 Branches 67 67 ======================================= Hits 277 277 Misses 13 13 Partials 1 1 ```
okinawaa commented 1 month ago

conflict만 해결 부탁드립니다 🙏

BO-LIKE-CHICKEN commented 1 month ago

감사합니다!

@okinawaa e6142b04159133dbcab6f2771baa88adf7aa4a45 와 conflict를 해결해 리뷰 요청드립니다 🙇🏻‍♂️