toss / es-hangul

A modern JavaScript library for handling Hangul characters.
https://es-hangul.slash.page/
MIT License
1.24k stars 83 forks source link

fix: eslint CI 오류 수정 #203

Closed kangju2000 closed 1 month ago

kangju2000 commented 1 month ago

Overview

Related to https://github.com/toss/es-hangul/issues/173

[AS-IS]

현재 CI에서 다음 사진과 같은 warning이 나타나 제대로 동작하지 않고 있습니다.

image

[TO-BE]

typescript-eslint v7.2.0부터 5.4.x 버전을 지원하고 있기 때문에, 7버전으로 업그레이드를 진행했니다.

또한, eslint의 버전을 7 -> 8로 변경했습니다. 버전업으로 인한 문제가 우려되어 마이그레이션 문서를 첨부합니다.

스크린샷 2024-07-27 오후 4 12 06

PR Checklist

  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: b227049b2389b01cc69bee315d7a45cb7284b2aa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jul 27, 2024 6:55am
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.18%. Comparing base (b6cde8e) to head (b227049).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-hangul/pull/203/graphs/tree.svg?width=650&height=150&src=pr&token=My9jTW6bSr&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-hangul/pull/203?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #203 +/- ## ======================================= Coverage 95.18% 95.18% ======================================= Files 17 17 Lines 291 291 Branches 67 67 ======================================= Hits 277 277 Misses 13 13 Partials 1 1 ```