Closed mass2527 closed 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
es-toolkit | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 29, 2024 1:25pm |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.69%. Comparing base (
b9966aa
) to head (5a22896
).
Actually, if takeRight
has a default parameter, it is not what we intended. We would like our users to provide explicit arguments to our functions.
@raon0211 Thanks for reviewing.
I assumed that the es-toolkit decided to add a default parameter, similar to lodash, since takeRight already had one. If this wasn't intentional, we might consider removing the default parameter from takeRight
.
Yes, that's right. We might remove the default parameter from takeRight
-- that was by accident.
then i will close this PR and make another pull request that remove default parameter from takeRight
I think
take
function should also have defaultcount
parameter liketakeRight
lodash
take
andtakeRight
both have default parameter.