Closed mass2527 closed 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
es-toolkit | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 31, 2024 5:33am |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.77%. Comparing base (
367fc87
) to head (023b0e7
). Report is 5 commits behind head on main.
@raon0211
Thanks for fixing it. I copied and pasted the code after testing by mistake.
I have one more thing to discuss: how about throwing an error if a non-integer or negative integer is passed, similar to how it was handled with before
?
Technically, we should, but it would bring a breaking change to our users, where code might suddenly break after updating our library. I'm a little concerned about that.. (Actually, removing the default parameters too)
We might discuss it in a separate issue or pull request.
Then we might include these kinds of changes in the next major update
Previous docs of
ary
had this following problems.Not only did I fix this issue, but I also simplified the example for clarity.