search

toss / es-toolkit

A modern JavaScript utility library that's 2-3 times faster and up to 97% smaller—a major upgrade to lodash.
https://es-toolkit.slash.page
Other
6.25k stars 263 forks source link

test: Remove duplicated test code #467

Closed mass2527 closed 1 week ago

mass2527 commented 2 weeks ago

I have removed the duplicate test code for initial and without that already exists in the src/compat/array folder.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2024 1:37pm
codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.78%. Comparing base (3a6cb36) to head (d36a36e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-toolkit/pull/467/graphs/tree.svg?width=650&height=150&src=pr&token=8N5S3AR3C7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-toolkit/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #467 +/- ## ======================================= Coverage 99.78% 99.78% ======================================= Files 171 171 Lines 1366 1366 Branches 364 364 ======================================= Hits 1363 1363 Misses 2 2 Partials 1 1 ```
mass2527 commented 1 week ago

You're right. However, both "initial" and "without" have two test files in the compat folder: one in compat/ and the other in compat/array. So i deleted files in compat/.

Is this also intentional?

raon0211 commented 1 week ago

This is intentional to keep track of whether we have compatibility with lodash.

mass2527 commented 1 week ago

Thanks for the explanation. I'll close this PR.