toss / es-toolkit

A modern JavaScript utility library that's 2-3 times faster and up to 97% smaller—a major upgrade to lodash.
https://es-toolkit.slash.page
Other
7.15k stars 329 forks source link

Backwards compatibility with yarn 1.x.x #722

Open saul-atomrigs opened 1 month ago

saul-atomrigs commented 1 month ago

Hello,

Situation

I forked, cloned and ran yarn in the root workspace but I got this error:

Captura de pantalla 2024-10-17 a las 2 41 42 p  m

Solution

It turns out, yarn 1.x.x still requires to have "private": true field in the root package.json (https://classic.yarnpkg.com/lang/en/docs/workspaces/#toc-how-to-use-it). Indeed, I added it and successfully installed the dependencies.

Captura de pantalla 2024-10-17 a las 2 44 39 p  m

Proposal

Can I open a pull request with this change? If there's another way, please let me know!

bang9 commented 1 month ago

This repository is using yarn@4.2.2. https://github.com/toss/es-toolkit/blob/main/package.json#L16

Would you like to enable corepack and try again?

saul-atomrigs commented 1 month ago

Hello @bang9 , corepack enable works too, so we have at least two possible solutions! 3 observations to note:

I'm open to add these changes