search

toss / es-toolkit

A modern JavaScript utility library that's 2-3 times faster and up to 97% smaller—a major upgrade to lodash.
https://es-toolkit.slash.page
Other
7.07k stars 325 forks source link

refactor(mapKeys): improved mapKeys function type #797

Closed ssi02014 closed 2 weeks ago

ssi02014 commented 2 weeks ago

In my opinion, there is no need to have 3 generic types, it would be simpler to define types with 2. What do you think?

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 9:06am
codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.14%. Comparing base (67ea6bf) to head (8aab58c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-toolkit/pull/797/graphs/tree.svg?width=650&height=150&src=pr&token=8N5S3AR3C7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-toolkit/pull/797?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #797 +/- ## ======================================= Coverage 99.14% 99.14% ======================================= Files 304 304 Lines 2689 2689 Branches 786 786 ======================================= Hits 2666 2666 Misses 22 22 Partials 1 1 ```