search

toss / es-toolkit

A modern JavaScript utility library that's 2-3 times faster and up to 97% smaller—a major upgrade to lodash.
https://es-toolkit.slash.page
Other
7.1k stars 329 forks source link

fix(compat): support PropertyKey #830

Closed D-Sketon closed 1 week ago

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 2:20pm
codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.96%. Comparing base (83c8a50) to head (0ee57db). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/es-toolkit/pull/830/graphs/tree.svg?width=650&height=150&src=pr&token=8N5S3AR3C7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/es-toolkit/pull/830?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #830 +/- ## =========================================== - Coverage 100.00% 99.96% -0.04% =========================================== Files 306 306 Lines 2727 2743 +16 Branches 802 818 +16 =========================================== + Hits 2727 2742 +15 - Misses 0 1 +1 ```
D-Sketon commented 1 week ago

BTW, should we change Record<string, unknown> to Record<PropertyKey, unknown> ?