search

toss / nestjs-aop

A way to gracefully apply AOP to nestjs
MIT License
213 stars 24 forks source link

[BUG]: scanFromPrototype deprecated #21

Closed kyoongdev closed 1 year ago

kyoongdev commented 1 year ago

src > auto-aspect-executor.ts

AS-IS

const methodNames = this.metadataScanner.scanFromPrototype(
        instance,
        Object.getPrototypeOf(instance),
        (name) => name,
);

TO-BE

const methodNames = this.metadataScanner.getAllMethodNames(instance);

=> method scanFromPrototype is deprecated

WhiteKiwi commented 1 year ago

세심한 제보 감사합니다 ㅎㅎ image

nestjs 8~9 버전을 지원하다 보니 의도적으로 scanFromPrototype을 사용하였어요 :) 최근에 10이 나왔는데 10에서 없어졌다면 관련해서 대응 고민해보도록 하겠습니다 🙇