`overlay.close` and `overlay.unmount`'s argument, parameter name matching

[jgjgill]

When I read docs, overlay.close and overlay.unmount arguments are overlayId.

But in the code, they are id as parameters.

events.ts

I think it would be more consistent if it was overlayId. what do you think?

[jungpaeng]

I don’t think the issue you pointed out significantly affects the usability of the library. However, I believe that small details like these contribute to the overall quality. Therefore, I agree that it would be better to align with the documentation for consistency.

I will make the changes. Thank you for pointing this out.

[jgjgill]

I don’t think the issue you pointed out significantly affects the usability of the library.

I agree. I thought the feature code was changing, as opposed to the test code or documentation, so I created an issue instead of writing a PR right away, even though it's a minor detail. 😂 If you haven't worked on it yet, can I write a PR and contribute to it? 🧐

[jungpaeng]

If you haven't worked on it yet, can I write a PR and contribute to it? 🧐

Sure! Contributing through a PR would be very helpful. Thank you!

[jgjgill]

Ok! I'm learning a lot thanks to you! 👍