search

toss / overlay-kit

The simplest and most intuitive way to manage overlays in React.
https://overlay-kit.slash.page
MIT License
295 stars 30 forks source link

Exporting types #80

Closed seungrodotlee closed 2 months ago

seungrodotlee commented 2 months ago

Hi @jungpaeng!

I have a suggestion. How about exporting some types used in overlay-kit? It would be useful for writing components that overlay. I think it would be great to be able to use the following examples.

overlay.open((overlayProps) => <SomeDialog {...overlayProps} />)

// SomeDialog
function SomeDialog({ isOpen, close }: OverlayProps) {
  // do something
}

(Anyway, It's very casual suggestion! 😃)

seungrodotlee commented 2 months ago

Upon reconsideration, I don't think it's a good idea, so I'm going to close it."