toss / suspensive

Packages to use React Suspense easily (one of Tanstack Query community resources)
https://suspensive.org
MIT License
417 stars 37 forks source link

feat(jotai): add @suspensive/jotai package #1042

Closed gwansikk closed 22 hours ago

gwansikk commented 3 days ago

Overview

Roadmap

Tests

Jul-07-2024 21-34-16

PR Checklist

  1. I read the Contributing Guide
  2. I added documents and tests.
vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 3:25am
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 3:25am
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 3:25am
changeset-bot[bot] commented 3 days ago

🦋 Changeset detected

Latest commit: b10b9467a968f277956086bb1a15998302eaab8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @suspensive/jotai | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.09%. Comparing base (bf2ac03) to head (b10b946).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/suspensive/pull/1042/graphs/tree.svg?width=650&height=150&src=pr&token=5PopssACmx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/suspensive/pull/1042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #1042 +/- ## ========================================== - Coverage 85.02% 84.09% -0.94% ========================================== Files 46 49 +3 Lines 541 547 +6 Branches 117 117 ========================================== Hits 460 460 - Misses 76 82 +6 Partials 5 5 ``` | [Components](https://app.codecov.io/gh/toss/suspensive/pull/1042/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | Coverage Δ | | |---|---|---| | [@suspensive/react](https://app.codecov.io/gh/toss/suspensive/pull/1042/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `97.03% <ø> (ø)` | | | [@suspensive/react-query](https://app.codecov.io/gh/toss/suspensive/pull/1042/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `75.28% <ø> (ø)` | | | [@suspensive/react-query-4](https://app.codecov.io/gh/toss/suspensive/pull/1042/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <ø> (ø)` | | | [@suspensive/react-query-5](https://app.codecov.io/gh/toss/suspensive/pull/1042/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <ø> (ø)` | | | [@suspensive/jotai](https://app.codecov.io/gh/toss/suspensive/pull/1042/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <0.00%> (∅)` | | | [@suspensive/react-await](https://app.codecov.io/gh/toss/suspensive/pull/1042/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `100.00% <ø> (ø)` | | | [@suspensive/react-image](https://app.codecov.io/gh/toss/suspensive/pull/1042/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `80.39% <ø> (ø)` | |
codspeed-hq[bot] commented 3 days ago

CodSpeed Performance Report

Merging #1042 will create unknown performance changes

Comparing jotai/feature/package (b10b946) with main (bf2ac03)

Summary

:warning: No benchmarks were detected in both the base of the PR and the PR.

manudeli commented 1 day ago

@gwansikk I will call you after making new Pull Request into this branch to modify this codes. could you review it later?

manudeli commented 1 day ago

https://github.com/toss/suspensive/pull/1045 I left improving Pull Request

gwansikk commented 23 hours ago

@gwansikk Could I merge first? In my opinion, interfaces should be improved and unified. But in zero version @suspensive/jotai could be improved even with BREAKING CHANGE. so It would be better that we release it first

In my opinion, It is better to merge first to create an environment where documentation and feature improvements can be worked on in parallel.

Yes, I agree! It seems better to deploy version 0.0.0 first and then make improvements.

manudeli commented 22 hours ago

@gwansikk I added @suspensive/jotai in codecov.yml at b10b946