Closed jgjgill closed 3 months ago
Latest commit: 10fcc6bc7365103f9189306d4e6b26a46090bc03
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
suspensive.org | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 13, 2024 3:59pm |
v1.suspensive.org | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 13, 2024 3:59pm |
visualization.suspensive.org | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 13, 2024 3:59pm |
@jgjgill is attempting to deploy a commit to the Toss Team on Vercel.
A member of the Team first needs to authorize it.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.23%. Comparing base (
f78700e
) to head (10fcc6b
).
Comparing jgjgill:test/error-boundary
(10fcc6b) with main
(f78700e)
:warning: No benchmarks were detected in both the base of the PR and the PR.
Overview
hello. I've been looking at the
ErrorBoundary
test code and trying to improve it.I did four things.
resetKeys.length
.shouldCatch
had all three cases, so I addedfalse
.shouldCatch
related tests only have tests that fail (NotChild
, OnlyParent
). I added tests that consider them all.user.click
, I addedawait
by returningPromise
.Thanks for the great library. 🙇♂️
PR Checklist