toss / suspensive

Manage asynchronous operations, timing, error handling, detecting intersection of elements, and caching easily and declaratively (One of TanStack Query community resources)
https://suspensive.org
MIT License
479 stars 45 forks source link

[Feature]: Do we need to re-export TanStack Query v5 interfaces by @suspensive/react-query-5 too #1096

Closed manudeli closed 1 month ago

manudeli commented 1 month ago

Package Scope

@suspensive/react-query-5

Description

@gwansikk In my opinion, re-exporting and marking it as deprecated jsdoc is good way to support TanStack Query v4 user to migrate to TanStack Query v5

Possible Solution

import { queryOptions, useSuspenseQuery, useSuspenseQueries, useSuspenseInfiniteQuery } from "@suspensive/react-query-5" // mark these as deprecated jsdoc

No response

etc.

No response

gwansikk commented 1 month ago

I think re-exported functions should be clearly marked with @deprecated to inform users.

manudeli commented 1 month ago

Users who originally use TanStack Query v5 can use it without confusion. (The same function names can cause confusion)

Yeah, this point is also important! Could I assign you again? @gwansikk

gwansikk commented 1 month ago

Yeah, this point is also important! Could I assign you again? @gwansikk

Of course!

gwansikk commented 1 month ago

@manudeli Once this issue is resolved, I would like to apply for inclusion in the TanStack Query v5 community resources. I think it's the right time. What do you think?

manudeli commented 1 month ago

@manudeli Once this issue is resolved, I would like to apply for inclusion in the TanStack Query v5 community resources. I think it's the right time. What do you think?

Cool! I agree