search

toss / suspensive

All in one for React Suspense
https://suspensive.org
MIT License
543 stars 52 forks source link

[Feature]: eslint flat config #1213

Closed manudeli closed 3 months ago

manudeli commented 3 months ago

Package Scope

etc

Description

eslint flat config

Possible Solution

No response

etc.

No response

vr-varad commented 3 months ago

@manudeli I would like to work on this issue if it is open for contribution.

coauthors[bot] commented 3 months ago

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli https://github.com/toss/suspensive/issues/1213#issuecomment-2298028539 https://github.com/toss/suspensive/issues/1213#issuecomment-2300606712 https://github.com/toss/suspensive/issues/1213#issuecomment-2302030276 https://github.com/toss/suspensive/issues/1213 4 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>
@vr-varad https://github.com/toss/suspensive/issues/1213#issuecomment-2297912391 https://github.com/toss/suspensive/issues/1213#issuecomment-2300721838 https://github.com/toss/suspensive/issues/1213#issuecomment-2301853250 https://github.com/toss/suspensive/issues/1213#issuecomment-2301855092 4 Co-authored-by: vr-varad <114755221+vr-varad@users.noreply.github.com>
manudeli commented 3 months ago

Sure! Make draft pr please to share your work early and when you ready to get review, request review to me please

manudeli commented 3 months ago

@vr-varad Share your plan trying to resolve this issue please if you can

vr-varad commented 3 months ago

Absolutely! Before making a pull request, I'll share a detailed plan as soon as possible. I'm currently working on it. @manudeli

vr-varad commented 3 months ago

ESLint Conversion to Flat Config: Condensed Plan

  1. Replacing Config Files:

    • Old: .eslintrc, .eslintrc.json, .eslintrc.yml
    • New: eslint.config.js

  2. Refactoring Structure:

    • Old: complex nested objects
    • New: array of configuration objects

  3. Convert Plugis:

    • Old: string plugins
    • New: module based imports
    • Example: import reactPlugin from 'eslint-plugin-react';

  4. Switch to ESM:

    • Old: module.exports
    • New: export default
vr-varad commented 3 months ago

@manudeli This is what I am thinking of implementing. Feel free to suggest changes whenever u are free

manudeli commented 3 months ago

@manudeli This is what I am thinking of implementing. Feel free to suggest changes whenever u are free

So good! Actually I tried to resolve this issue once and failed. I will try to help you in your PR. Let's implement it