search

toss / suspensive

All in one for React Suspense
https://suspensive.org
MIT License
541 stars 52 forks source link

tsconfig allowJS & eslint all js check #1332

Closed manudeli closed 1 week ago

manudeli commented 1 month ago 
          I respect your opinion, and I believe that excluding checks for .js files in ESLint settings might be a somewhat regrettable choice. ESLint provides various rules that help maintain code conventions, and these rules still hold significant meaning for files that do not use TypeScript. For example, rules like import/order and prettier can greatly enhance code readability and maintain consistency within the project. From this perspective, I think it is more desirable to apply ESLint checks to all files.

_Originally posted by @SEOKKAMONI in https://github.com/toss/suspensive/pull/1326#discussion_r1807385579_

coauthors[bot] commented 1 month ago

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli https://github.com/toss/suspensive/issues/1332#issuecomment-2477045381 https://github.com/toss/suspensive/issues/1332 2 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>
manudeli commented 1 week ago

@SEOKKAMONI In my opinion, this is not something we must do right now, so I'll close it for now. Feel free to reopen if you think otherwise.