toss / suspensive

All in one for React Suspense
https://suspensive.org
MIT License
540 stars 52 forks source link

fix: React Native Playground Configuration #1352

Closed XionWCFM closed 1 week ago

XionWCFM commented 1 week ago

Overview

Configure an environment to run React Native Playground.

Guide

  1. install dependencies
pnpm i
  1. run project
cd examples/react-native-playground
pnpm run start
i
  1. The following screen will be displayed:
Screenshot 2024-11-13 at 18 08 25 Screenshot 2024-11-13 at 18 12 07

Test

built the entire project and confirmed that it was built without a problem.

Trouble Shooting

React Native is sensitive to cache and nodemodule state.

If it doesn't work well, delete the entire nodemodules and cache folders in the project and try again.

ETC

I realized that public-hoist-pattern[]=* is not the same as node-linker=hoisted, but rather the same as setting shamefully-hoist to true.

I set node-linker=hoisted in another project and experienced next15's build failing during the CI process.

By default, pnpm manages dependencies strictly so that only specified dependencies are used.

However, if you set this setting, you will give up strict dependency management and manage dependencies similar to the method of older generation package managers such as yarn and npm.

Should we give up the functionality of pnpm? I wish there was another way to solve this problem.

I think I can use it until I find another way. shamefully-hoist and public-hoist-pattern[]=*

coauthors[bot] commented 1 week ago

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli https://github.com/toss/suspensive/pull/1352#discussion_r1839868685 https://github.com/toss/suspensive/pull/1352#discussion_r1839869057 https://github.com/toss/suspensive/pull/1352#discussion_r1839871610 https://github.com/toss/suspensive/pull/1352#discussion_r1839887738 https://github.com/toss/suspensive/pull/1352#discussion_r1839970037 https://github.com/toss/suspensive/pull/1352#discussion_r1839976799 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2432489628 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2432490257 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2432494329 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2432520393 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2432649671 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2432659140 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2434188701 https://github.com/toss/suspensive/pull/1352#issuecomment-2473080388 14 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>
@XionWCFM https://github.com/toss/suspensive/pull/1352#discussion_r1839875923 https://github.com/toss/suspensive/pull/1352#discussion_r1839892514 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2432500814 https://github.com/toss/suspensive/pull/1352#pullrequestreview-2432527879 https://github.com/toss/suspensive/pull/1352#issuecomment-2473110235 https://github.com/toss/suspensive/pull/1352#issuecomment-2473140382 https://github.com/toss/suspensive/pull/1352 7 Co-authored-by: XionWCFM <101111364+XionWCFM@users.noreply.github.com>
@codecov-commenter https://github.com/toss/suspensive/pull/1352#issuecomment-2473176305 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>
changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 24dd2385929e383343fb7e67cd44b9a7364bba05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 7:06pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 7:06pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 7:06pm
vercel[bot] commented 1 week ago

@XionWCFM is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #1352 will create unknown performance changes

Comparing XionWCFM:rnsetup (24dd238) with main (ed96eea)

Summary

:warning: No benchmarks were detected in both the base of the PR and the PR.

manudeli commented 1 week ago

@XionWCFM Could you resolve https://github.com/toss/suspensive/actions/runs/11814909318/job/32915046140?pr=1352 this ci error please?

XionWCFM commented 1 week ago

In my other projects, when I set hoisted, a problem occurred in another next15

Please understand that we may create a few more commits for testing in CI.

XionWCFM commented 1 week ago

Could you please run a workflow for this commit? @manudeli

If this commit doesn't work, you may have to use the hacky solution I originally suggested for CI.

(use a different .npmrc locally only)

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.86%. Comparing base (ed96eea) to head (24dd238).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/suspensive/pull/1352/graphs/tree.svg?width=650&height=150&src=pr&token=5PopssACmx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/suspensive/pull/1352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #1352 +/- ## ======================================= Coverage 71.86% 71.86% ======================================= Files 67 67 Lines 583 583 Branches 129 129 ======================================= Hits 419 419 Misses 151 151 Partials 13 13 ``` | [Components](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | Coverage Δ | | |---|---|---| | [@suspensive/react](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `100.00% <ø> (ø)` | | | [@suspensive/react-dom](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `100.00% <ø> (ø)` | | | [@suspensive/react-native](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `100.00% <ø> (ø)` | | | [@suspensive/react-query](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `72.86% <ø> (ø)` | | | [@suspensive/react-query-4](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <ø> (ø)` | | | [@suspensive/react-query-5](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <ø> (ø)` | | | [@suspensive/jotai](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <ø> (ø)` | | | [@suspensive/codemods](https://app.codecov.io/gh/toss/suspensive/pull/1352/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `41.97% <ø> (ø)` | |