toss / suspensive

All in one for React Suspense
https://suspensive.org
MIT License
541 stars 52 forks source link

feat(react-native-playground): remove shamefully-hoist and expo 52 version upgrade #1356

Closed XionWCFM closed 1 week ago

XionWCFM commented 1 week ago

Overview

With the addition of support for pnpm monorepo in expo 52, you can now disable "shamefully hoist" and "node-linker=hoisted".

expo sdk 52 release

Accordingly, we upgrade the existing react-native-playground's expo version to 52 and remove "public-hoist-pattern[]=*".

As a result of testing, if you use the monorepo pattern without hoisting, it works fine locally, but causes problems in EAS remote builds.

However, Playground is not expected to require EAS remote build.

I guess the benefits of not using the hoisting pattern are greater.

Test

I confirmed that the IOS Simulator operates locally and that the entire build process operates.

Trouble Shooting

During the migration process, I often failed to start the expo app due to the cache of metro or packagemanager.

Most problems are caused by mismatched ReactNative versions.

If you are having this problem try

pnpm store prune
pnpm i

pnpm store prune docs

PR Checklist

  1. I read the Contributing Guide
  2. I added documents and tests.
changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: e6254041a772a08e7ea425951dcc2b39adddd1c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coauthors[bot] commented 1 week ago

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli https://github.com/toss/suspensive/pull/1356#discussion_r1842603803 https://github.com/toss/suspensive/pull/1356#pullrequestreview-2436720389 https://github.com/toss/suspensive/pull/1356#pullrequestreview-2436722431 3 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>
@XionWCFM https://github.com/toss/suspensive/pull/1356 1 Co-authored-by: XionWCFM <101111364+XionWCFM@users.noreply.github.com>
@codecov-commenter https://github.com/toss/suspensive/pull/1356#issuecomment-2475910024 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>
vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ❌ Failed (Inspect) Nov 14, 2024 5:10pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:10pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:10pm
vercel[bot] commented 1 week ago

@XionWCFM is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #1356 will create unknown performance changes

Comparing XionWCFM:expoversion (e625404) with main (e7e80b1)

Summary

:warning: No benchmarks were detected in both the base of the PR and the PR.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.86%. Comparing base (e7e80b1) to head (e625404).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/toss/suspensive/pull/1356/graphs/tree.svg?width=650&height=150&src=pr&token=5PopssACmx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss)](https://app.codecov.io/gh/toss/suspensive/pull/1356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) ```diff @@ Coverage Diff @@ ## main #1356 +/- ## ======================================= Coverage 71.86% 71.86% ======================================= Files 67 67 Lines 583 583 Branches 129 129 ======================================= Hits 419 419 Misses 151 151 Partials 13 13 ``` | [Components](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | Coverage Δ | | |---|---|---| | [@suspensive/react](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `100.00% <ø> (ø)` | | | [@suspensive/react-dom](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `100.00% <ø> (ø)` | | | [@suspensive/react-native](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `100.00% <ø> (ø)` | | | [@suspensive/react-query](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `72.86% <ø> (ø)` | | | [@suspensive/react-query-4](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <ø> (ø)` | | | [@suspensive/react-query-5](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <ø> (ø)` | | | [@suspensive/jotai](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `0.00% <ø> (ø)` | | | [@suspensive/codemods](https://app.codecov.io/gh/toss/suspensive/pull/1356/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=toss) | `41.97% <ø> (ø)` | |