Closed XionWCFM closed 1 week ago
Latest commit: e6254041a772a08e7ea425951dcc2b39adddd1c7
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Candidate | Reasons | Count | Add this as commit message |
---|---|---|---|
@manudeli | https://github.com/toss/suspensive/pull/1356#discussion_r1842603803 https://github.com/toss/suspensive/pull/1356#pullrequestreview-2436720389 https://github.com/toss/suspensive/pull/1356#pullrequestreview-2436722431 | 3 | Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com> |
@XionWCFM | https://github.com/toss/suspensive/pull/1356 | 1 | Co-authored-by: XionWCFM <101111364+XionWCFM@users.noreply.github.com> |
@codecov-commenter | https://github.com/toss/suspensive/pull/1356#issuecomment-2475910024 | 1 | Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com> |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
suspensive.org | ❌ Failed (Inspect) | Nov 14, 2024 5:10pm | ||
v1.suspensive.org | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 14, 2024 5:10pm |
visualization.suspensive.org | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 14, 2024 5:10pm |
@XionWCFM is attempting to deploy a commit to the Toss Team on Vercel.
A member of the Team first needs to authorize it.
Comparing XionWCFM:expoversion
(e625404) with main
(e7e80b1)
:warning: No benchmarks were detected in both the base of the PR and the PR.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.86%. Comparing base (
e7e80b1
) to head (e625404
).
Overview
With the addition of support for pnpm monorepo in expo 52, you can now disable "shamefully hoist" and "node-linker=hoisted".
expo sdk 52 release
Accordingly, we upgrade the existing react-native-playground's expo version to 52 and remove "public-hoist-pattern[]=*".
As a result of testing, if you use the monorepo pattern without hoisting, it works fine locally, but causes problems in EAS remote builds.
However, Playground is not expected to require EAS remote build.
I guess the benefits of not using the hoisting pattern are greater.
Test
I confirmed that the IOS Simulator operates locally and that the entire build process operates.
Trouble Shooting
During the migration process, I often failed to start the expo app due to the cache of metro or packagemanager.
Most problems are caused by mismatched ReactNative versions.
If you are having this problem try
pnpm store prune docs
PR Checklist