Fixed DeFi return types

tosunthex / CoinGecko

CoinGecko .Net Standard api wrapper

111 stars 46 forks source link

Fixed DeFi return types #20

Closed shommey closed 3 years ago

shommey commented 3 years ago

This fixes bugs introduced in my previous PR #19

Bug; The method for getting the Global DeFi (/global/decentralized_finance_defi) endpoint returns Global (/global) endpoint.

Expected behavior: The method returns Global DeFi endopint (/global/decentralized_finance_defi)

Changes:

Fixed return types for DeFi endpoint
Renamed "DeFi" class to "GlobalDeFi" to avoid confusion in case CoinGecko introduce some more DeFi endpoints
Changed DeFi data from double to decimal

shommey commented 3 years ago

@tosunthex Happy to help, even though it isn't much, it's my first contribution. Sorry about the obj and bin folders, it looked like they were already part of the repo, that's why I didn't ignore them. Noted.