tosunthex / CoinGecko

CoinGecko .Net Standard api wrapper
111 stars 46 forks source link

Missing "order" parameter in GetCoinMarkets #36

Closed walltechco closed 2 years ago

walltechco commented 2 years ago

The "order" parameter of the /coins/markets API query is missing from the query string dictionary in the GetCoinMarkets method of the CoinsClient class.

        public async Task<List<CoinMarkets>> GetCoinMarkets(string vsCurrency, string[] ids, string order, int? perPage,
            int? page, bool sparkline, string priceChangePercentage,string category)
        {
            return await GetAsync<List<CoinMarkets>>(QueryStringService.AppendQueryString(CoinsApiEndPoints.CoinMarkets,
                new Dictionary<string, object>
                {
                    {"vs_currency", vsCurrency},
                    {"ids", string.Join(",", ids)},
                    {"order", order}, <---------   this line is missing
                    {"per_page", perPage},
                    {"page", page},
                    {"sparkline", sparkline},
                    {"price_change_percentage", priceChangePercentage},
                    {"category",category}
                })).ConfigureAwait(false);
        }
tosunthex commented 2 years ago

Hi @walltechco, thanks for the Issue. I made changed and publish new package