tot3lmon / avant-window-navigator

Automatically exported from code.google.com/p/avant-window-navigator
GNU General Public License v2.0
0 stars 0 forks source link

Rhythmbox ArtDisplayPlugin Refactor #288

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
This plug-in is based on a copy (quite old) of ArtDisplayPlugin ... It is
hard to maintain and lead to code copy.

What is the expected output? What do you see instead?
Python is OO ... so a sub class seems a better idea (or any other
crosscutting concern tool).

What version of the product are you using? On what operating system?
svn 214, ubuntu feisty

Please provide any additional information below.
I don't knwon many things in python .. but i'm quite familiar with oo.
So i try it to do something ... and there is a patch or somethings thats
looklike a patch ;).

Currently there is an issue in this patch, but i don't how python manages
file namespace. ArtDisplay needs a file called
'rhythmbox-missing-artwork.svg', i suppose that the current dir is the
module, and i don't know how getting a module path to redefine (maybe
overide) the ART_MISSING_ICON const.

To install it, just untar the attached file in .gnome2/rhythmbox/plugin.
In rhythmbox disable ArtDisplay, and enable ArtDisplay-awn to ...

That's all.

Original issue reported on code.google.com by florealm on 9 Jul 2007 at 7:56

Attachments:

GoogleCodeExporter commented 8 years ago
Grrr a mistake is hidden in this file ... sorry ... i upload the good one

Original comment by florealm on 9 Jul 2007 at 10:17

Attachments:

GoogleCodeExporter commented 8 years ago
Oh, this is excellent, thank you. 

I'll add into svn asap.

--Neil

Original comment by njpa...@gmail.com on 14 Jul 2007 at 7:55

GoogleCodeExporter commented 8 years ago
Neil, what's the status on this, and how does it relate to issue 286? Both have 
patches

Original comment by nekoh...@gmail.com on 26 Jul 2007 at 7:41