total-typescript / ts-reset

A 'CSS reset' for TypeScript, improving types for common JavaScript API's
https://www.totaltypescript.com/ts-reset
MIT License
7.74k stars 117 forks source link

Improvement Suggestions for the Repository #162

Closed MDReal32 closed 2 months ago

MDReal32 commented 11 months ago

Hello! I've been following your content on YouTube and really appreciate the valuable information you share. Thank you for that!

I've taken the liberty to enhance the repository in a few ways:

These improvements aim to enhance the readability, maintainability, and usability of the repository. Please feel free to review these changes and adapt them according to your preferences. Your input is always valued. Thanks again for your fantastic content!

NateLevin1 commented 11 months ago

Was the description of this PR generated by ChatGPT? These changes are pretty substantial (almost entirely breaking changes), you may just want to keep your own fork instead of merging with this repository.

MDReal32 commented 11 months ago

No. Its not generated by ChatGPT. just fixed my grammatical problems. Yeah it braking changes. It can be released in next major update.

mattpocock commented 2 months ago

Apologies, this PR is too large to merge. Individually, we could discuss these pieces and get them merged one by one. But I'm unsure about each of them:

I'm happy with the directory structure the way it is.

I don't want to change the way users import this library, this seems to be an unnecessary breaking change.

There is an argument that we should be automatically generating the exports map - but I also quite like keeping it simple.